From 0ba47039f8fa85f3f2ee3cd41235ca8cf76de683 Mon Sep 17 00:00:00 2001 From: rkcf Date: Sat, 28 Jan 2023 11:17:27 -0600 Subject: [PATCH] refactor change if/else to switch case --- main/esp32-sequencer.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/main/esp32-sequencer.c b/main/esp32-sequencer.c index 640818d..eafb3e5 100644 --- a/main/esp32-sequencer.c +++ b/main/esp32-sequencer.c @@ -90,6 +90,7 @@ static void control_event_handler(void* arg) { switch (gpio_num) { case GPIO_MUTATE_BTN: mutate_seq(sequence); + break; } } } @@ -254,20 +255,27 @@ static void ledc_init(void) { static void blink_led(ledc_channel_t channel) { ESP_ERROR_CHECK(ledc_set_duty(LEDC_LOW_SPEED_MODE, channel, 4095)); ESP_ERROR_CHECK(ledc_update_duty(LEDC_LOW_SPEED_MODE, channel)); - - if (channel == LEDC_CHANNEL_0) { + switch (channel) { + case (LEDC_CHANNEL_0): ESP_ERROR_CHECK(gptimer_start(clk_blink_timer)); - } else if (channel == LEDC_CHANNEL_1) { + break; + case (LEDC_CHANNEL_1): ESP_ERROR_CHECK(gptimer_start(gate_blink_timer)); + break; + default: + break; } } static void pulse_cv(uint8_t gpio_num) { gpio_set_level(gpio_num, 1); - if (gpio_num == GPIO_CLK_OUT) { + switch (gpio_num) { + case (GPIO_CLK_OUT): ESP_ERROR_CHECK(gptimer_start(clk_cv_timer)); - } else if (gpio_num == GPIO_GATE_OUT) { + break; + case (GPIO_GATE_OUT): ESP_ERROR_CHECK(gptimer_start(gate_cv_timer)); + break; } }