refactor change if/else to switch case

main
rkcf 2023-01-28 11:17:27 -06:00
parent 000afa2062
commit 0ba47039f8
1 changed files with 13 additions and 5 deletions

View File

@ -90,6 +90,7 @@ static void control_event_handler(void* arg) {
switch (gpio_num) { switch (gpio_num) {
case GPIO_MUTATE_BTN: case GPIO_MUTATE_BTN:
mutate_seq(sequence); mutate_seq(sequence);
break;
} }
} }
} }
@ -254,20 +255,27 @@ static void ledc_init(void) {
static void blink_led(ledc_channel_t channel) { static void blink_led(ledc_channel_t channel) {
ESP_ERROR_CHECK(ledc_set_duty(LEDC_LOW_SPEED_MODE, channel, 4095)); ESP_ERROR_CHECK(ledc_set_duty(LEDC_LOW_SPEED_MODE, channel, 4095));
ESP_ERROR_CHECK(ledc_update_duty(LEDC_LOW_SPEED_MODE, channel)); ESP_ERROR_CHECK(ledc_update_duty(LEDC_LOW_SPEED_MODE, channel));
switch (channel) {
if (channel == LEDC_CHANNEL_0) { case (LEDC_CHANNEL_0):
ESP_ERROR_CHECK(gptimer_start(clk_blink_timer)); ESP_ERROR_CHECK(gptimer_start(clk_blink_timer));
} else if (channel == LEDC_CHANNEL_1) { break;
case (LEDC_CHANNEL_1):
ESP_ERROR_CHECK(gptimer_start(gate_blink_timer)); ESP_ERROR_CHECK(gptimer_start(gate_blink_timer));
break;
default:
break;
} }
} }
static void pulse_cv(uint8_t gpio_num) { static void pulse_cv(uint8_t gpio_num) {
gpio_set_level(gpio_num, 1); gpio_set_level(gpio_num, 1);
if (gpio_num == GPIO_CLK_OUT) { switch (gpio_num) {
case (GPIO_CLK_OUT):
ESP_ERROR_CHECK(gptimer_start(clk_cv_timer)); ESP_ERROR_CHECK(gptimer_start(clk_cv_timer));
} else if (gpio_num == GPIO_GATE_OUT) { break;
case (GPIO_GATE_OUT):
ESP_ERROR_CHECK(gptimer_start(gate_cv_timer)); ESP_ERROR_CHECK(gptimer_start(gate_cv_timer));
break;
} }
} }